Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: change the name to NotarySigningKeyProperties #410

Merged
merged 2 commits into from
Jan 17, 2024
Merged

style: change the name to NotarySigningKeyProperties #410

merged 2 commits into from
Jan 17, 2024

Conversation

themighty1
Copy link
Member

No description provided.

yuroitaki
yuroitaki reviewed Jan 16, 2024
View reviewed changes
Copy link
Member

@yuroitaki yuroitaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just need to update those in the integration_test.rs as well

@themighty1
Copy link
Member Author

Looks good! Just need to update those in the integration_test.rs as well

done

yuroitaki
yuroitaki approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@yuroitaki yuroitaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks again~ oh good catch on the config yaml

@themighty1 themighty1 merged commit 6bf4e87 into dev Jan 17, 2024
15 checks passed
@sinui0 sinui0 deleted the fix_naming_in_notaryserver branch February 14, 2024 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuroitaki yuroitaki yuroitaki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@themighty1 @yuroitaki